Skip to content

Improve log for stateful API check#6497

Merged
sudo-shashank merged 2 commits intomainfrom
shashank/log-stateful-api
Jan 29, 2026
Merged

Improve log for stateful API check#6497
sudo-shashank merged 2 commits intomainfrom
shashank/log-stateful-api

Conversation

@sudo-shashank
Copy link
Copy Markdown
Contributor

@sudo-shashank sudo-shashank commented Jan 28, 2026 •
edited by coderabbitai Bot
Loading

Summary of changes

Changes introduced in this pull request:

  • Add log which will help to investigate if eth_new_pending_transaction_filter check fails in stateful API check.

Reference issue to close (if applicable)

Closes #6462

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Enhanced error messages and assertions in Ethereum API filter operations for improved debugging and diagnostics.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 28, 2026 •
edited
Loading

Walkthrough

This PR improves error diagnostics in stateful API tests by refining ownership handling and enhancing error messages. The changes address flaky test conditions in eth_get_filter_logs and eth_new_pending_transaction_filter by using references where appropriate and providing more detailed failure context.

Changes

Cohort / File(s) Summary
Stateful API test improvements
src/tool/subcommands/api_cmd/stateful_tests.rs		 Enhanced eth_new_pending_transaction_filter with reference iteration (&hashes) and improved assertions with detailed error messages showing prev_hashes, hashes, cid, and cids. Updated eth_get_filter_logs error message formatting for filter_spec and cid using debug output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

RPC

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: improving logging for stateful API checks to help diagnose failures.
Linked Issues check ✅ Passed The PR adds detailed error messages and logging to eth_new_pending_transaction_filter and eth_get_filter_logs functions to help diagnose the flaky stateful API check failures reported in issue #6462.
Out of Scope Changes check ✅ Passed All changes are directly related to improving logging and error messages for the stateful API check functions, which is within the scope defined by issue #6462.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank marked this pull request as ready for review January 28, 2026 21:09
@sudo-shashank sudo-shashank requested a review from a team as a code owner January 28, 2026 21:09
@sudo-shashank sudo-shashank requested review from akaladarshi and hanabi1224 and removed request for a team January 28, 2026 21:09
@sudo-shashank sudo-shashank added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 7bffdd6 Jan 29, 2026
39 of 40 checks passed
@sudo-shashank sudo-shashank deleted the shashank/log-stateful-api branch January 29, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@akaladarshi akaladarshi Awaiting requested review from akaladarshi akaladarshi is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stateful API checks fails periodically

2 participants

@sudo-shashank @hanabi1224